On Wednesday, 3 June 2026 at 12:07, Steven Wilton <swilton@fluentit.au> wrote:
Hi,
I have gone through the RFC process for a bunch of new functionality for
the SNMP module and wanted to check if there's anything else I need to
do to move this forward, or if it's in the queue and waiting for the
appropriate releases?
Hello Steven,
I'll have a look next week after I come back from a conference as I will need to learn about SNMP.
Best regards,
Gina P. Banyard
On 25/06/2026 8:47 pm, Gina P. Banyard wrote:
On Wednesday, 3 June 2026 at 12:07, Steven Wilton<swilton@fluentit.au> wrote:
Hi,
I have gone through the RFC process for a bunch of new functionality for
the SNMP module and wanted to check if there's anything else I need to
do to move this forward, or if it's in the queue and waiting for the
appropriate releases?Hello Steven,
I'll have a look next week after I come back from a conference as I will need to learn about SNMP.
Best regards,
Gina P. Banyard
Hi Gina,
Thanks for your willingness to help get this merged. When you're ready to look at it, I'll be very happy to help with showing what difference the new functionality makes. I expect that 2 of the PRs should be fairly straightforward.
regards
Steve
On 25/06/2026 8:47 pm, Gina P. Banyard wrote:
On Wednesday, 3 June 2026 at 12:07, Steven Wilton <swilton@fluentit.au> wrote:
Hi,
I have gone through the RFC process for a bunch of new functionality for
the SNMP module and wanted to check if there's anything else I need to
do to move this forward, or if it's in the queue and waiting for the
appropriate releases?Hello Steven,
I'll have a look next week after I come back from a conference as I will need to learn about SNMP.
Best regards,
Gina P. Banyard
Hi Gina,
I've updated the security protocol PR based on your comment (I agree with the suggested simplification), so that should hopefully be ready now.
I think I've fixed the formatting option PR as requested, with the exception of the const definitions in the snmp.stub.php file. I've extended the existing technique of using the values from the net-snmp library, and I think it works quite well (it avoids having to map from the PHP SNMP_* values back to the equivalent net-nsmp NETSNMP_* values). All code in the php-snmp module checks that a valid value has been passed before use. I will change this if you can see additional benefits (I may need some guidance on the correct way to achieve this), but I personally like the way the existing code works, and changing it would require modifying the original php-snmp code.
Can you please have a look at the PRs for the 2 items above and let me know if they are ready to squash and merge. Once the above 2 are done I can rebase the third PR and get that ready for merging.
regards
Steve