Contributing to php-src with features and bug fixes, DanielEScherzer · GitHub
Hi internals.
On Fri, Mar 21, 2025 at 3:11 PM Daniel Scherzer <daniel.e.scherzer@gmail.com> wrote:
Contributing to php-src with features and bug fixes, https://github.com/DanielEScherzer
Since there wasn’t much space in the form field to fill out the details, I’ve been contributing to various parts of the code base, mostly around attributes, the generated stubs, and the reflection extension, as well as trying to clean up some of the test organization. I am the author of two RFCs ([1], [2]), the first passed and the second is still under discussion.
If granted access I would also volunteer to take on maintaining the reflection extension, which per EXTENSIONS in php-src does not currently have a primary maintainer.
I was encouraged by cmb69 to apply for an account 6 months ago[3], and have also privately gotten encouragement from Ilija to apply (the form said that this should be noted in the request but there didn’t seem to be space).
Let me know if there are any questions I can answer,
–Daniel Scherzer
[1] https://wiki.php.net/rfc/attributes-on-constants
[2] https://wiki.php.net/rfc/never-parameters-v2
[3] https://github.com/php/php-src/pull/15977#issuecomment-2366983138
Hi Daniel
On Mar 21 2025, at 11:17 pm, Daniel Scherzer daniel.e.scherzer@gmail.com wrote:
Contributing to php-src with features and bug fixes, https://github.com/DanielEScherzer
Your account has been approved. You should have received an e-mail with a GitHub invitation. Derick also granted you the corresponding karma for your wiki account.
Please familiarize yourself with our Git workflow:
https://wiki.php.net/vcs/gitworkflow
https://wiki.php.net/vcs/gitfaq
Feel free to ping me if you have any problems or questions.
Thank you for your contributions!
Ilija
On Tue, Mar 25, 2025 at 5:11 PM Ilija Tovilo <tovilo.ilija@gmail.com> wrote:
Hi Daniel
Derick also granted you the corresponding karma for your wiki account.
How can I check if this went through? I don’t see any new option to vote on https://wiki.php.net/rfc/optional-interfaces.
-Daniel
On 3/25/25 19:13, Daniel Scherzer wrote:
On Tue, Mar 25, 2025 at 5:11 PM Ilija Tovilo <tovilo.ilija@gmail.com> wrote:
Hi Daniel
Derick also granted you the corresponding karma for your wiki account.
How can I check if this went through? I don't see any new option to vote on
PHP: rfc:optional-interfaces.-Daniel
If you're logged in on the wiki, you should see the option to vote at the very bottom of the table, down where the results are counted.
Cheers,
Ben
On 26.03.2025 at 01:13, Daniel Scherzer wrote:
On Tue, Mar 25, 2025 at 5:11 PM Ilija Tovilo <tovilo.ilija@gmail.com> wrote:
Derick also granted you the corresponding karma for your wiki account.
How can I check if this went through? I don't see any new option to vote on
PHP: rfc:optional-interfaces.
The Wiki account is irrelevant for voting; only the PHP account is. So
you may need to log out as danielescherzer first, and then log in as
daniels.
Christoph