[PHP-DEV] Json error - better message

juan_carlos_morales · July 16, 2024, 4:51pm

Hello Internals again:

I created this pull request:

github.com/php/php-src

better json error message

php:master ← juan-morales:rfc-json-errormsg

opened 01:07PM - 26 Jun 24 UTC

juan-morales

+147 -20

I will propose this RFC today, but I did a PoC change just to have an idea about… how to do it. In short, the idea is to have better error messages, instead of having an error message saying "Syntax Error", to have something like "Syntax Error - error at character X near content " foo: bar }" .... 😄 This is still Work in progress. Eventhough is not finished, and I have to write the email to the email list, I want to say ...... Thanks in advance @derickr because you gave me the idea, ... exactly on this moment of history: [What's New in PHP 8.3 - Derick Rethans](https://youtu.be/3U0DGhzSH2U?feature=shared&t=2480) I also tag you @bukka so you know since now, that I am doing this, as all this part of php was mainly ... you 😄 still Work In Progress, and will be done soon. Hope this change makes sense, and also makes PHP greater.

To have better error messages when decoding a JSON in php using the
json_last_error_msg() function.

With this change I pretend to have a message like:

"Syntax error, at character 0 near content: blah"

I would like to heard your comments about it and if you have comments
about implementation please write your comments in the PR.

I hope we can get this done soon.

thanks in advance.

Juan

juan_carlos_morales · July 22, 2024, 12:13pm

El El mar, 16 jul 2024 a la(s) 1:51 p. m., juan carlos morales <dev.juan.morales@gmail.com> escribió:

Hello Internals again:

I created this pull request:

https://github.com/php/php-src/pull/14672

To have better error messages when decoding a JSON in php using the
json_last_error_msg() function.

With this change I pretend to have a message like:

“Syntax error, at character 0 near content: blah”

I would like to heard your comments about it and if you have comments
about implementation please write your comments in the PR.

I hope we can get this done soon.

thanks in advance.

Juan

Hello internals, I kindly ask for help, as the PR is getting some comments. Whoever can participate is welcome. Hopefully we can get this small but (in my opinión) useful change quickly.

Thanks in advance