Hi,
The DatePeriod class works based on DateTimeInterface but does not take the microsecond of the date-time instance into account [1].
To fix that I have opened a small PR [2] 2 months ago which got approved quickly as well but nothing more happened until then.
I'm wring here to kindly ask if this can be merged to be included in 8.4 or if I should do something else?
[1] DatePeriod not taking into account microseconds for end date · Issue #13773 · php/php-src · GitHub
[2] fixes #13773: DatePeriod does not take microseconds into account by marc-mabe · Pull Request #14581 · php/php-src · GitHub
Thanks,
Marc
On 21 August 2024 09:59:53 BST, Marc Bennewitz <marc@mabe.berlin> wrote:
Hi,
The DatePeriod class works based on DateTimeInterface but does not take the microsecond of the date-time instance into account [1].
To fix that I have opened a small PR [2] 2 months ago which got approved quickly as well but nothing more happened until then.
I'm wring here to kindly ask if this can be merged to be included in 8.4 or if I should do something else?
[1] DatePeriod not taking into account microseconds for end date · Issue #13773 · php/php-src · GitHub
[2] fixes #13773: DatePeriod does not take microseconds into account by marc-mabe · Pull Request #14581 · php/php-src · GitHub
Thanks,
Marc
I'll get this sorted. IMO this is also a bug fix, but as we are in feature freeze I'll ask thr release managers.
cheers
Derick