[PHP-DEV] Adding attributes to compile-time constants

Mailing Lists php.internals
1

Hi internals,

For the last few weeks, I’ve been working on a patch[1] that I just uploaded that adds support for attributes on compile-time non-class constants (those declared with const rather than via define()). The patch has a memory leak that I have been unable to resolve, but otherwise the functionality is there and seems to work. Is anyone willing to help with the memory issue?

Separately, once the memory issue is fixed, would this need to go through an RFC process?

Thanks,
–Daniel Scherzer

[1] https://github.com/php/php-src/pull/16952

2

On Tue, Nov 26, 2024, at 2:15 PM, Daniel Scherzer wrote:

Hi internals,

For the last few weeks, I've been working on a patch[1] that I just
uploaded that adds support for attributes on compile-time non-class
constants (those declared with `const` rather than via `define()`). The
patch has a memory leak that I have been unable to resolve, but
otherwise the functionality is there and seems to work. Is anyone
willing to help with the memory issue?

Separately, once the memory issue is fixed, would this need to go
through an RFC process?

Thanks,
--Daniel Scherzer

[1] Add support for attributes on compile-time constants by DanielEScherzer · Pull Request #16952 · php/php-src · GitHub

I believe it would require an RFC, though I expect it would pass easily. I'm no help on the memory question though, I'm afraid.

--Larry Garfield

3

Hi

Am 2024-11-26 21:39, schrieb Larry Garfield:

I believe it would require an RFC, though I expect it would pass easily.

I agree. Attributes on regular constants introduce new syntax, which is a pretty clear language change and thus requires an RFC.

Best regards
Tim Düsterhus

4

Since it seems that this requires an RFC, I have created an account on wiki.php.net with the username danielescherzer and kindly request edit privileges so that I can create the RFC.

-Daniel

On Tue, Nov 26, 2024 at 12:15 PM Daniel Scherzer <daniel.e.scherzer@gmail.com> wrote:

Hi internals,

For the last few weeks, I’ve been working on a patch[1] that I just uploaded that adds support for attributes on compile-time non-class constants (those declared with const rather than via define()). The patch has a memory leak that I have been unable to resolve, but otherwise the functionality is there and seems to work. Is anyone willing to help with the memory issue?

Separately, once the memory issue is fixed, would this need to go through an RFC process?

Thanks,
–Daniel Scherzer

[1] https://github.com/php/php-src/pull/16952

5

On 30.11.2024 at 11:59, Daniel Scherzer wrote:

Since it seems that this requires an RFC, I have created an account on
wiki.php.net with the username `danielescherzer` and kindly request edit
privileges so that I can create the RFC.

RFC karma granted. Best of luck with the RFC!

Christoph