Hi Jordan,
It looks pretty good. It should probably give specific guidelines on how "no scale provided" works for addition, subtraction, multiplication, division, and exponentiation. The section now doesn't make it clear that the returned scale will behave differently for addition (the current example) than for division.
I see, I'll add that later, thanks!
Regards.
Saki
Hi,
I added some examples, corrected incorrect explanations, etc. Now that the specifications have been fairly finalized and the RFC has been clarified, I would like everyone to check it out again.
https://wiki.php.net/rfc/support_object_type_in_bcmath
Regards.
Saki
Am 04.04.2024 um 08:29 schrieb Saki Takamachi <saki@sakiot.com>:
I added some examples, corrected incorrect explanations, etc. Now that the specifications have been fairly finalized and the RFC has been clarified, I would like everyone to check it out again.
Looks very promising!
The default value for rounding is PHP_ROUND_TOWARD_ZERO. Is this because it is the same as the BCMath functions for consistency only or do you expect this to be the most used rounding mode?
I didn't find any discussion about this choice, sorry if I missed it.
Regards,
- Chris
Hi Chris,
Looks very promising!
The default value for rounding is PHP_ROUND_TOWARD_ZERO. Is this because it is the same as the BCMath functions for consistency only or do you expect this to be the most used rounding mode?
I didn't find any discussion about this choice, sorry if I missed it.
Thank you!
Yes, you're right, I've made it match the existing behavior of BCMath. And rest assured, there has been no discussion about that yet.
I haven't thought about it in detail yet, but maybe there are other ideal initial values?
Regards.
Saki
Hi
[cleaning out CC list]
On 4/4/24 08:29, Saki Takamachi wrote:
I added some examples, corrected incorrect explanations, etc. Now that the specifications have been fairly finalized and the RFC has been clarified, I would like everyone to check it out again.
Can you please clean up the RFC text? I find the “Updated X/X” bits confusing, because I'm not sure whether this is what the RFC is going to propose, or whether this is something that was superseded by the following discussion.
The Wiki already provides a version history should folks be interested in what has actually changed.
Another tip regarding Wiki syntax: By using <PHP> instead of <code> the code examples will get syntax highlighting, making them more readable.
Best regards
Tim Düsterhus
Hi Tim,
Can you please clean up the RFC text? I find the “Updated X/X” bits confusing, because I'm not sure whether this is what the RFC is going to propose, or whether this is something that was superseded by the following discussion.
The Wiki already provides a version history should folks be interested in what has actually changed.
Another tip regarding Wiki syntax: By using <PHP> instead of <code> the code examples will get syntax highlighting, making them more readable.
Thank you for teaching me. I will fix it later!
Regards.
Saki