Just for the record I voted No on those isset and empty warnings as I don’t think they should be emitting warning in this case - it might be quite surprising for users and have a BC impact for them (e.g. they might be checking output from internals functions where false is returned and currently they don’t need to care for that which I think make more sense for those functions).
I have now closed the votes for the "Warnings for PHP 8.5" RFC:
The following proposals have been accepted:
- Warn when coercing NAN to other types (20 yay, 0 nay, 100%)
- Casting out of range floats to int (17 yay, 0 nay, 100%)
- Destructuring non-array values (16 yay, 0 nay, 100%)
The following proposals have been declined:
- Warn when using offsets on non-container values in isset()/empty() (10 yay, 6 nay, 62.5%)
- Warn when using invalid offset types when checking string offsets with isset()/empty() (10 yay, 6 nay, 62.5%)
Thank you to everyone that has voted and participated in the discussions.