[PHP-DEV] Deprecate mhash constants?

Mailing Lists php.internals
1

Hi all,

recently, it was discovered that although the mhash functions are
deprecated as of PHP 8.1.0[1], the mhash constants are not yet
deprecated. I believe that was just an oversight, since the are well
hidden in the sources, and we don't even have them in the stub files[2].

I made a PR to actually deprecate the constants[3]. Does anybody feel
this needs the RFC process?

[1] <PHP: rfc:deprecations_php_8_1;
[2] <Issues · php/doc-en · GitHub;
[3] <https://github.com/php/php-src/pull/16569&gt;

Christoph

2

They should have been deprecated back then. No RFC needed.

3

On 25/10/2024 19:24, Christoph M. Becker wrote:

Hi all,

recently, it was discovered that although the mhash functions are
deprecated as of PHP 8.1.0[1], the mhash constants are not yet
deprecated. I believe that was just an oversight, since the are well
hidden in the sources, and we don't even have them in the stub files[2].

I made a PR to actually deprecate the constants[3]. Does anybody feel
this needs the RFC process?

[1] <PHP: rfc:deprecations_php_8_1;
[2] <Issues · php/doc-en · GitHub;
[3] <https://github.com/php/php-src/pull/16569&gt;

Christoph

Since their intended use is deprecated, just deprecate them already too :slight_smile:

Kind regards
Niels